Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorise les URL munin #6296

Merged
merged 2 commits into from
Jul 3, 2022
Merged

Refactorise les URL munin #6296

merged 2 commits into from
Jul 3, 2022

Conversation

Arnaud-D
Copy link
Contributor

@Arnaud-D Arnaud-D commented May 7, 2022

Lié à #6246.

Au menu de cette refacto des URL munin : path au lieu de re_path.

Contrôle qualité

Je ne sais pas trop comment vérifier... J'ai pas du tout touché à la forme du motif, donc ça devrait passer, mais l'optimisme, c'est pas de la QA.

@Arnaud-D Arnaud-D added C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité labels May 7, 2022
@coveralls
Copy link

coveralls commented May 7, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 88.001% when pulling 094bf41 on Arnaud-D:passez_votre_chemin_refacto_urls_en_cours_5 into dbf1e27 on zestedesavoir:dev.

@Arnaud-D Arnaud-D force-pushed the passez_votre_chemin_refacto_urls_en_cours_5 branch from dafa245 to a7653bb Compare June 2, 2022 21:42
@Arnaud-D Arnaud-D force-pushed the passez_votre_chemin_refacto_urls_en_cours_5 branch from a7653bb to 32d8a10 Compare June 26, 2022 16:55
philippemilink
philippemilink approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QAisé en simplement saisissant les URLs impactées dans le navigateur et voyant qu'on ne se prend pas une 404, mais bien des statistiques correspondant à l'URL demandée.

QA OK ✔️

@philippemilink philippemilink enabled auto-merge (squash) July 3, 2022 16:55
@philippemilink philippemilink merged commit 3d5e6ce into zestedesavoir:dev Jul 3, 2022
@Arnaud-D Arnaud-D deleted the passez_votre_chemin_refacto_urls_en_cours_5 branch July 3, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemilink philippemilink philippemilink approved these changes

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité
Projects
Suivi des PR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arnaud-D @coveralls @philippemilink